aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jing Chen <milantr...@gmail.com>
Subject Re: Review Request 54624: Expose stats on ZooKeeper connection state
Date Tue, 20 Dec 2016 09:33:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54624/
-----------------------------------------------------------

(Updated Dec. 20, 2016, 9:33 a.m.)


Review request for Aurora, Joshua Cohen, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.


Changes
-------

per review feedback, add binary gauge to export current connection state, keep counters to
keep track of state appearance times


Bugs: AURORA-1838
    https://issues.apache.org/jira/browse/AURORA-1838


Repository: aurora


Description
-------

Expose stats on ZooKeeper connection state


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java 999a542796858dcfe9e31601c47239189043fd52


Diff: https://reviews.apache.org/r/54624/diff/


Testing (updated)
-------

http://192.168.33.7:8081/vars
```
zk_connection_state_CONNECTED 1
zk_connection_state_CONNECTED_counter 1
zk_connection_state_LOST 0
zk_connection_state_LOST_counter 0
zk_connection_state_READ_ONLY 0
zk_connection_state_READ_ONLY_counter 0
zk_connection_state_RECONNECTED 0
zk_connection_state_RECONNECTED_counter 0
zk_connection_state_SUSPENDED 0
zk_connection_state_SUSPENDED_counter 0
```

* zk_connection_state_STATE shows 1 if STATE is current connection state, otherwise 0.
* zk_connection_state_STATE_counter represents occurence times of the STATE since scheduler
state


Thanks,

Jing Chen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message