aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 54847: Remove ignored snapshot stats. Add high-level timings on storage start-up lifecycle.
Date Mon, 19 Dec 2016 17:13:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54847/#review159622
-----------------------------------------------------------


Ship it!




Ship It!

- Stephan Erb


On Dec. 19, 2016, 12:51 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54847/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2016, 12:51 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The stats I added around SnapshotFields are not applied because they are not Guice-created
instances. I've just removed them for now (adding timings manually would be very repetitive
here so there's probably a better abstraction we can use).
> 
> I added metrics to cover two pretty large parts of the Scheduler start-up time: storage.prepare
and storage.start.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 9c9218ca6294eaddeb47b274393603bf47af61a8

>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 239f2eb475bec20acfcc2990d5d933f5bec83ed4

> 
> Diff: https://reviews.apache.org/r/54847/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message