aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot
Date Fri, 16 Dec 2016 15:20:30 GMT


> On Dec. 16, 2016, 1:13 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java, lines
69-72
> > <https://reviews.apache.org/r/54774/diff/6/?file=1586548#file1586548line69>
> >
> >     I feel like we should change the default to an empty set. The largest number
of Aurora users will not need those fields and there is therefore no need to populate those
by default.

I think at least for one release it should match the current behavior. After 0.18.0 we can
default it to empty?


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54774/#review159433
-----------------------------------------------------------


On Dec. 15, 2016, 8:04 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54774/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2016, 8:04 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and Zameer Manji.
> 
> 
> Bugs: AURORA-1861
>     https://issues.apache.org/jira/browse/AURORA-1861
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Motivation: Thanks to the mybatis query metrics we added, we found that double writing
Snapshot fields for H2 stores adds considerable overhead to our snapshot creation time. 
> 
> Snapshots are also written as backups, and many operators choose to process backups offline
for analytics, rather than query the live scheduler (due to not being able to scale reads
horizontally). So this allows operators to enable/disable the hydrated fields as needed.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 3fa408e283f91b313633959ea6d2e730d4dc0771

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 7dcd1bfcf303cf374e9a6627cb6c632ccea098f2

>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 853780bc68400489578ed3692920aafcec42c999

>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 7a11850e217dcb0148e4a4d33542c95b2e53a726

>   src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java cf0a8f3ea11e9c48d1f16441af54dc781b33bdfc

> 
> Diff: https://reviews.apache.org/r/54774/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew test
> 
> Applied this to an internal test cluster with the update hydration disabled and verified
snapshots and backups and failover.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message