aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David McLaughlin <>
Subject Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot
Date Thu, 15 Dec 2016 17:59:22 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 15, 2016, 5:59 p.m.)

Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and Zameer Manji.


Put this feature behind a flag.

Bugs: AURORA-1861

Repository: aurora


Motivation: Thanks to the mybatis query metrics we added, we found that the redundant query
I'm removing here currently adds 20s to the snapshot creation time. This is an extra 20s unavailability
every time we snapshot on our prod clusters. 


Avoid double writing job updates to the Scheduler Snapshot. This should be low-risk because:

1) Job Updates have *never* had an in-memory store implementation. 
2) They are also relatively new, so the chances of some old code processing job updates from
backups is fairly low?

Diffs (updated)

  src/main/java/org/apache/aurora/scheduler/storage/backup/ 3fa408e283f91b313633959ea6d2e730d4dc0771

  src/main/java/org/apache/aurora/scheduler/storage/log/ 7dcd1bfcf303cf374e9a6627cb6c632ccea098f2

  src/main/java/org/apache/aurora/scheduler/storage/log/ d2c859055f905ac76ee8eb387dca103b9857ddbe

  src/test/java/org/apache/aurora/scheduler/storage/backup/ 7a11850e217dcb0148e4a4d33542c95b2e53a726

  src/test/java/org/apache/aurora/scheduler/storage/log/ cf0a8f3ea11e9c48d1f16441af54dc781b33bdfc



./gradlew test

I'll apply this to one of our test clusters before merging to master too.


David McLaughlin

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message