aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 54754: Fixed starting cron jobs when using default_docker_parameters
Date Wed, 14 Dec 2016 17:51:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54754/#review159189
-----------------------------------------------------------



This patch does not apply cleanly against master (220e23b), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 14, 2016, 5:46 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54754/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 5:46 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1684
>     https://issues.apache.org/jira/browse/AURORA-1684
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixed starting cron jobs when using default_docker_parameters
> 
> The code was previously attempting to re-sanitize the configuration read from storage
rather than just using it as is.  This causes issues if after sanitization the job no longer
passes sanitization (which is the case here w/ default_docker_parameters).
> 
> We've been running this in our branch forever.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java c07551e94f9221b5b21c5dc9715e82caa290c2e8

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 650facecc2e02be7bb3cd5ea9ff0f094e006bcb3

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 5c64ff2994e200b3453603ac5470e8e152cebc55

> 
> Diff: https://reviews.apache.org/r/54754/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message