aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Niemitz <sniem...@twitter.com>
Subject Review Request 54754: Fixed starting cron jobs when using default_docker_parameters
Date Wed, 14 Dec 2016 17:00:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54754/
-----------------------------------------------------------

Review request for Aurora.


Repository: aurora


Description
-------

Fixed starting cron jobs when using default_docker_parameters

The code was previously attempting to re-sanitize the configuration read from storage rather
than just using it as is.  This causes issues if after sanitization the job no longer passes
sanitization (which is the case here w/ default_docker_parameters).

We've been running this in our branch forever.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java c07551e94f9221b5b21c5dc9715e82caa290c2e8

  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 650facecc2e02be7bb3cd5ea9ff0f094e006bcb3


Diff: https://reviews.apache.org/r/54754/diff/


Testing
-------


Thanks,

Steve Niemitz


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message