aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David McLaughlin <da...@dmclaughlin.com>
Subject Re: Review Request 54624: Expose stats on ZooKeeper connection state
Date Tue, 13 Dec 2016 21:09:28 GMT


> On Dec. 12, 2016, 10:15 p.m., Mehrdad Nurolahzade wrote:
> > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java,
lines 135-151
> > <https://reviews.apache.org/r/54624/diff/2/?file=1581612#file1581612line135>
> >
> >     I would rather prefer binary state (0/1 value) to counter-like stats here. See
`org.apache.aurora.scheduler.SchedulerLifecycle` as an example.
> 
> Stephan Erb wrote:
>     Binary state gauges have the disadvantage that they only show the presence. This
would imply we need to scrape `/vars` pretty often in order to detect ZK connection problems.
Counters don't have that limitation.
> 
> Mehrdad Nurolahzade wrote:
>     I agree. Perhaps I am baised here because we already have a solution for polling
and diagraming stats internally.
>     So, in your world, how are going to use counters to contemplate current state?

We want both. A Gauge stat for current connection state and absolute counters for the events
(as they are now).


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54624/#review158871
-----------------------------------------------------------


On Dec. 12, 2016, 1:32 a.m., Jing Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54624/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 1:32 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Mehrdad Nurolahzade, Stephan Erb, and Zameer
Manji.
> 
> 
> Bugs: AURORA-1838
>     https://issues.apache.org/jira/browse/AURORA-1838
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Expose stats on ZooKeeper connection state
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
999a542796858dcfe9e31601c47239189043fd52 
> 
> Diff: https://reviews.apache.org/r/54624/diff/
> 
> 
> Testing
> -------
> 
> http://192.168.33.7:8081/vars
> ```
> zk_connection_state_connected 1
> zk_connection_state_lost 0
> zk_connection_state_readonly 0
> zk_connection_state_reconnected 0
> zk_connection_state_suspended 0
> zk_connection_state_unknown 0
> ```
> 
> 
> Thanks,
> 
> Jing Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message