aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Review Request 54567: Fixup prepare_binary.sh to work under modern bash.
Date Fri, 09 Dec 2016 03:58:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54567/
-----------------------------------------------------------

Review request for Aurora and Joshua Cohen.


Repository: aurora


Description
-------

Previously pushd/popd were used and these emit data to stdout muddying
pants output and breaking setup of the thrift serve dir structure.

 build-support/thrift/prepare_binary.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)


Diffs
-----

  build-support/thrift/prepare_binary.sh e3b46aa1f36ed3eecc9bb7794073d18dd950eb1c 

Diff: https://reviews.apache.org/r/54567/diff/


Testing
-------

Reproduced the current master CI failure before this change on my linux machine.
Fixed with this change.


Thanks,

John Sirois


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message