aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.
Date Fri, 09 Dec 2016 03:30:32 GMT


> On Dec. 8, 2016, 8:29 p.m., John Sirois wrote:
> > build-support/thrift/prepare_binary.sh, line 29
> > <https://reviews.apache.org/r/54550/diff/3/?file=1580209#file1580209line29>
> >
> >     aha - popd on linux echos the dirstack - presumably it does not do this on osx...
so needs a re-direct.  Ditto pushd. And AuroraBot really does need to go green.

...where linux probably just means modern bash, osx - even Sierra IIUC, is wtfb (way tf behind).


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54550/#review158632
-----------------------------------------------------------


On Dec. 8, 2016, 7:30 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54550/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2016, 7:30 p.m.)
> 
> 
> Review request for Aurora and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We have some CI machines internally where the default python doesn't have the `json`
module, so this script fails.
> 
> 
> Diffs
> -----
> 
>   build-support/thrift/prepare_binary.sh a96b33e4564604f72d8fcf284f0cf1adea1866a9 
> 
> Diff: https://reviews.apache.org/r/54550/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message