aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.
Date Fri, 09 Dec 2016 02:27:33 GMT


> On Dec. 9, 2016, 2:22 a.m., Zameer Manji wrote:
> > build-support/thrift/prepare_binary.sh, line 3
> > <https://reviews.apache.org/r/54550/diff/2/?file=1580208#file1580208line3>
> >
> >     To be consistent can you do `set -o xtrace`?

TIL


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54550/#review158625
-----------------------------------------------------------


On Dec. 9, 2016, 2:15 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54550/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2016, 2:15 a.m.)
> 
> 
> Review request for Aurora and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We have some CI machines internally where the default python doesn't have the `json`
module, so this script fails.
> 
> 
> Diffs
> -----
> 
>   build-support/thrift/prepare_binary.sh a96b33e4564604f72d8fcf284f0cf1adea1866a9 
> 
> Diff: https://reviews.apache.org/r/54550/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message