aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <>
Subject Re: Review Request 54288: Make leader elections resilient to ZK disconnections.
Date Thu, 08 Dec 2016 23:28:31 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 8, 2016, 3:28 p.m.)

Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb.


Take Karthik's suggestion and fix a possible timing issue in the failing test.

Bugs: AURORA-1669

Repository: aurora


As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates
leadership if the ZK connection is lost or if there is a timeout. This is not
compatible with the commons based implementation which would only abdicate
leadership if the ZK session timeout occurred.

This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a
custom listener that only loses leadership if a connection loss occurs.

Diffs (updated)

  src/main/java/org/apache/aurora/scheduler/discovery/ c378172c850aafe0a9381552b5067277b40dbfab

  src/test/java/org/apache/aurora/scheduler/discovery/ a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583

  src/test/java/org/apache/aurora/scheduler/discovery/ 6ea49b0c690d288ff59d1d4798144bfa2d153d3a




Zameer Manji

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message