aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 54255: Update to Mesos 1.1.0.
Date Wed, 07 Dec 2016 19:19:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54255/#review158370
-----------------------------------------------------------




RELEASE-NOTES.md (line 5)
<https://reviews.apache.org/r/54255/#comment229131>

    You mean 1.1.0 right?



build-support/python/make-mesos-native-egg (line 60)
<https://reviews.apache.org/r/54255/#comment229136>

    I think here we want to set the `MAKEFLAGS` environment variable instead.
    
    https://www.gnu.org/software/make/manual/html_node/Options_002fRecursion.html
    
    ```
    The ‘-j’ option is a special case (see Parallel Execution). If you set it to some
numeric value ‘N’ and your operating system supports it (most any UNIX system will; others
typically won’t), the parent make and all the sub-makes will communicate to ensure that
there are only ‘N’ jobs running at the same time between them all. Note that any job that
is marked recursive (see Instead of Executing Recipes) doesn’t count against the total jobs
(otherwise we could get ‘N’ sub-makes running and have no slots left over for any real
work!)
    ```
    
    I think the mesos make files have recursive make invocations in them, so this is more
desirable.



src/main/java/org/apache/aurora/scheduler/base/Conversions.java (line 67)
<https://reviews.apache.org/r/54255/#comment229137>

    Can you reference AURORA-1814 in this comment please?


- Zameer Manji


On Dec. 7, 2016, 3:04 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54255/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 3:04 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1813
>     https://issues.apache.org/jira/browse/AURORA-1813
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Included changes:
> 
> * Handle new task states introduced in the latest Mesos release.
> * Prevent NullPointer exception when inspecting an empty/invalid executor config in a
test.
>   Probably this is due to a change in the Mesos protobufs.
> * Fix bug preventing the teardown of Vagrant boxes started by the egg build.
> * Increase resources for the Mesos egg builds. The build for all distribution now takes
2h in total.
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126 
>   RELEASE-NOTES.md 90c4793b218f54ad92ab4da5049d5e92c3a104b3 
>   Vagrantfile c20c7861095de0f81dbf57c617640e24257b52b4 
>   build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd 
>   build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca

>   build.gradle 7064bcace19a183c41e04c4ac7a6944df6063d2a 
>   src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376

>   src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
7dc9eff2c7058e90eb93f7d7f4f378e8883989e5 
> 
> Diff: https://reviews.apache.org/r/54255/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message