aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 54439: Add support for an mttu metric (median time to updated)
Date Wed, 07 Dec 2016 17:50:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54439/
-----------------------------------------------------------

(Updated Dec. 7, 2016, 5:50 p.m.)


Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Zameer Manji.


Changes
-------

Add task index to the mttu calculation to avoid iterating tasks for every job update.


Repository: aurora


Description
-------

The metric is calculated from the time of the `INSTANCE_UPDATING` event to the subsequent
`ASSIGNED` event for the task with the same instance id that matches the desired task config
from the update details.

My original approach to this involved converting `GroupType` and `AlgorithmType` from enums
(which cannot be generic) to static classes (which, of course, can). This allowed me to avoid
unnecessarily passing update details to the `calculate` method of `SlaAlgorithm` since it's
ignored in all but the one, new case. However, that ended up being a lot of churn, and since
it turns out we need both the task details and the update details to calculate this metric,
I went with the below approach. If anyone feels strongly, I could go back to generics and
create an container class that's gives access to both the tasks and update details.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 9a56cda809fbbcb07e6dd12c7a0feb272542491d

  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 5d8d5bd8f705770979f284d26d2e932aabe707e5

  src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java 6fbd4e962b3bb6eeb0831c810a321478fd52172c

  src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 953b65f28a585375e36e305dea6f9f94f99abc93

  src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 2e719ac6b7aea86faa22deff2cc6b5f73135761c

  src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 341e346e794c9cf9a2789b8799f38fff900ec9b3

  src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java 78f440f7546de9ed6842cb51db02b3bddc9a74ff

  src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 21d26b3930ea965487b2dec48a48a98677ba022b

  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 43e32eede27bbf26363a3fd1ca34ffe6f8c01a73

  src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 6d0e9bc6a8040393875d4f0a88e8db9d6926a88b


Diff: https://reviews.apache.org/r/54439/diff/


Testing
-------

./gradlew build -Pq
e2e tests.


Thanks,

Joshua Cohen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message