aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 54459: Add message parameter to killTasks
Date Wed, 07 Dec 2016 00:47:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review158280
-----------------------------------------------------------



Master (91ddb07) is red with this patch.
  ./build-support/jenkins/build.sh

  Running setup.py bdist_wheel for cov-core: started
  Running setup.py bdist_wheel for cov-core: finished with status 'done'
  Stored in directory: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/86/e1/c2/9ff8cfe9773ce07003f2c2be096e169af4614c2f634671d49b
  Running setup.py bdist_wheel for pycparser: started
  Running setup.py bdist_wheel for pycparser: finished with status 'done'
  Stored in directory: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/a8/0b/41/dc95621f9d3a0da7bc191b8a71f0e8182ffd3cc5f33ac55005
  Running setup.py bdist_wheel for twitter.common.options: started
  Running setup.py bdist_wheel for twitter.common.options: finished with status 'done'
  Stored in directory: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/17/41/80/c4811d8c1c7ca7007e520c3399872fc340f45c3a26a6a23e6a
Successfully built pantsbuild.pants twitter.common.collections setproctitle ansicolors pathspec
scandir twitter.common.dirutil pystache psutil docutils Markdown Pygments twitter.common.confluence
coverage pytest pytest-cov lmdb pywatchman twitter.common.lang twitter.common.log cov-core
pycparser twitter.common.options
Installing collected packages: twitter.common.lang, twitter.common.collections, setproctitle,
setuptools, six, ansicolors, pyparsing, packaging, pathspec, scandir, twitter.common.dirutil,
requests, pystache, psutil, pex, docutils, Markdown, Pygments, twitter.common.options, twitter.common.log,
twitter.common.confluence, monotonic, fasteners, coverage, py, pytest, cov-core, pytest-cov,
futures, pycparser, cffi, lmdb, pywatchman, pantsbuild.pants
  Found existing installation: setuptools 21.2.1
    Uninstalling setuptools-21.2.1:
      Successfully uninstalled setuptools-21.2.1
Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 cffi-1.7.0 cov-core-1.15.0
coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 lmdb-0.89 monotonic-1.2 packaging-16.7
pantsbuild.pants-1.3.0.dev0 pathspec-0.3.4 pex-1.1.13 psutil-4.3.0 py-1.4.31 pycparser-2.17
pyparsing-2.1.10 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 pywatchman-1.3.0 requests-2.5.3
scandir-1.2 setproctitle-1.1.10 setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.9
twitter.common.confluence-0.3.9 twitter.common.dirutil-0.3.9 twitter.common.lang-0.3.9 twitter.common.log-0.3.9
twitter.common.options-0.3.9
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

00:47:05 00:00 [main]
               (To run a reporting server: ./pants server)
00:47:05 00:00   [setup]
00:47:05 00:00     [parse]
               Executing tasks in goals: compile
00:47:05 00:00   [compile]
00:47:05 00:00     [compile-prep-command]
00:47:05 00:00     [compile]
00:47:05 00:00     [python-eval]
00:47:05 00:00     [pythonstyle]
00:47:05 00:00       [cache]                                           
                   No cached artifacts for 43 targets.
                   Invalidated 43 targets.
E501:ERROR   PythonFile(src/test/python/apache/aurora/client/cli/test_kill.py):256 line too
long (101 > 100 characters)
     |      kill_calls = [call(cls.TEST_JOBKEY, [i], config=None, message=message) for i in
instance_range]


FAILURE: 1 Python Style issues found. For import order related issues, please try `./pants
fmt.isort <targets>`


00:47:30 00:25   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 7, 2016, 12:37 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 12:37 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include
with the induced job update state change." This diff provides a similar optional parameter
for the killTasks RPC, which allows users to indicate the reason why a task was killed, and
later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message
"Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template
"Killed by <user>", separated by a newline. For the above example, this looks like:
"Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7

>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1

>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc

>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d

>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38

>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff

>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java
05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
b28cd2489a52041a8e7e53f298fad8d8cd29406f 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef

>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc

>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912

> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message