Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3D9E9200BD0 for ; Wed, 30 Nov 2016 07:28:17 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3C3E5160B13; Wed, 30 Nov 2016 06:28:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8622C160B08 for ; Wed, 30 Nov 2016 07:28:16 +0100 (CET) Received: (qmail 92142 invoked by uid 500); 30 Nov 2016 06:28:15 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 92118 invoked by uid 99); 30 Nov 2016 06:28:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2016 06:28:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5D8FC2F73B8; Wed, 30 Nov 2016 06:28:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5221468942978430153==" MIME-Version: 1.0 Subject: Re: Review Request 54106: SlaUtil::percentile percentiles interpolation From: Reza Motamedi To: Santhosh Kumar Shanmugham , David McLaughlin , Joshua Cohen Cc: Aurora , Reza Motamedi , Aurora ReviewBot Date: Wed, 30 Nov 2016 06:28:13 -0000 Message-ID: <20161130062813.5575.29451@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Reza Motamedi X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54106/ X-Sender: Reza Motamedi References: <20161129224436.5576.63736@reviews.apache.org> In-Reply-To: <20161129224436.5576.63736@reviews.apache.org> X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/sla/SlaUtilTest.java Reply-To: Reza Motamedi X-ReviewRequest-Repository: aurora archived-at: Wed, 30 Nov 2016 06:28:17 -0000 --===============5221468942978430153== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54106/ ----------------------------------------------------------- (Updated Nov. 30, 2016, 6:28 a.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Santhosh Kumar Shanmugham. Changes ------- Addressed comments in feedback. Repository: aurora Description ------- __Modification to SlaUtil::percentile to compute percentiles by interpolation__ The calculation of mttX (median-time-to-X) depends on the computation of percentile values. The current implementation does not behave nicely with a small sample size. For instance, for a given sample set of {50, 150}, 50-percentile is reported to be 50. Although, 100 seems a more appropriate return value. This patch uses Guava's Quantile for interpolation. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 263647e802b664fd3ea21cef8109fb7a9252356f src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java 156b9c0a2fa0c0ec4b7220d5ec2cc40c3e59d1d6 src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java eca1beebc906d3354d8c294ba466bc904bde98fa src/test/java/org/apache/aurora/scheduler/sla/SlaUtilTest.java PRE-CREATION Diff: https://reviews.apache.org/r/54106/diff/ Testing ------- Tests added and modified to match the continuous distribution. I also exported the tests into excel and check the reports percentiles. Thanks, Reza Motamedi --===============5221468942978430153==--