Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============6610904762122574900=="
MIME-Version: 1.0
Subject: Re: Review Request 51993: Added the 'reason' to the /pendingTasks
 endpoint
From: Pradyumna Kaushik <pkaushi1@binghamton.edu>
To: Joshua Cohen <jcohen@apache.org>
Cc: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>,
 Pradyumna Kaushik <pkaushi1@binghamton.edu>,
 Aurora ReviewBot <wfarner@apache.org>, Stephan Erb <serb@apache.org>,
 Maxim Khutornenko <maxim@apache.org>, Zameer Manji <zmanji@apache.org>,
 Aurora <reviews@aurora.apache.org>
Date: Mon, 28 Nov 2016 20:35:39 -0000
Message-ID: <20161128203539.5575.59406@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Pradyumna Kaushik <noreply@reviews.apache.org>
References: <20161128160358.5575.39029@reviews.apache.org>
In-Reply-To: <20161128160358.5575.39029@reviews.apache.org>
Reply-To: Pradyumna Kaushik <pkaushi1@binghamton.edu>
archived-at: Mon, 28 Nov 2016 20:35:43 -0000

--===============6610904762122574900==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Nov. 28, 2016, 4:03 p.m., Joshua Cohen wrote:
> > Sorry for the delay on this, everything looks good to me, just a few style/maintainability nits, then it's good to go!

@jcohen. I have made the necessary changes and have posted the patch for review. Thank you.


- Pradyumna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51993/#review157037
-----------------------------------------------------------


On Nov. 28, 2016, 8:34 p.m., Pradyumna Kaushik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51993/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 8:34 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1762
>     https://issues.apache.org/jira/browse/AURORA-1762
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added the 'reason' to the /pendingTasks endpoint
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt 84265066001dee79df6bc16de6de9a165e912b9b 
>   src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java c80e0c8adf80e12082a6952ae79b7d9cc960c5b6 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java f783e7ff220573915524a1efc27141193d19fa6c 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java b521620badff76e8fab0bdf31f8a73c4019b2121 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 77187bc19fb1f783d1b820d324c7fe18e509365f 
>   src/test/java/org/apache/aurora/scheduler/http/OffersTest.java 9e3573252cf37153180b1fc5ab9150bab0299c99 
>   src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/TestUtils.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java d9b3cc672f42c50b2a2a142733d26c0725bbc864 
> 
> Diff: https://reviews.apache.org/r/51993/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Pradyumna Kaushik
> 
>


--===============6610904762122574900==--