aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reza Motamedi <>
Subject Re: Review Request 54106: SlaUtil::percentile percentiles interpolation
Date Wed, 30 Nov 2016 06:28:13 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 30, 2016, 6:28 a.m.)

Review request for Aurora, David McLaughlin, Joshua Cohen, and Santhosh Kumar Shanmugham.


Addressed comments in feedback.

Repository: aurora


__Modification to SlaUtil::percentile to compute percentiles by interpolation__

The calculation of mttX (median-time-to-X) depends on the computation of percentile values.
The current implementation does not behave nicely with a small sample size. For instance,
for a given sample set of  {50, 150}, 50-percentile is reported to be 50. Although, 100 seems
a more appropriate return value.

This patch uses Guava's Quantile for interpolation.

Diffs (updated)

  src/main/java/org/apache/aurora/scheduler/sla/ 263647e802b664fd3ea21cef8109fb7a9252356f

  src/main/java/org/apache/aurora/scheduler/sla/ 156b9c0a2fa0c0ec4b7220d5ec2cc40c3e59d1d6

  src/test/java/org/apache/aurora/scheduler/sla/ eca1beebc906d3354d8c294ba466bc904bde98fa

  src/test/java/org/apache/aurora/scheduler/sla/ PRE-CREATION 



Tests added and modified to match the continuous distribution.
I also exported the tests into excel and check the reports percentiles.


Reza Motamedi

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message