aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 54106: SlaUtil::percentile percentiles interpolation
Date Wed, 30 Nov 2016 00:04:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54106/#review157349
-----------------------------------------------------------




src/test/java/org/apache/aurora/scheduler/sla/SlaUtilTest.java (lines 16 - 24)
<https://reviews.apache.org/r/54106/#comment227898>

    Remove extra tabs.



src/test/java/org/apache/aurora/scheduler/sla/SlaUtilTest.java (line 26)
<https://reviews.apache.org/r/54106/#comment227910>

    Please add 0th and 100th percentile to the testcases to enfore the boundary condition.



src/test/java/org/apache/aurora/scheduler/sla/SlaUtilTest.java (lines 120 - 127)
<https://reviews.apache.org/r/54106/#comment227911>

    I am getting different numbers, from a spreadsheet,
    
    p75  = 75
    p99  = 89.4
    p999 = 89.94


- Santhosh Kumar Shanmugham


On Nov. 29, 2016, 2:44 p.m., Reza Motamedi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54106/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 2:44 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> __Modification to SlaUtil::percentile to compute percentiles by interpolation__
> 
> The calculation of mttX (median-time-to-X) depends on the computation of percentile values.
The current implementation does not behave nicely with a small sample size. For instance,
for a given sample set of  {50, 150}, 50-percentile is reported to be 50. Although, 100 seems
a more appropriate return value.
> 
> This patch uses Guava's Quantile for interpolation.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 263647e802b664fd3ea21cef8109fb7a9252356f

>   src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java 156b9c0a2fa0c0ec4b7220d5ec2cc40c3e59d1d6

>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java eca1beebc906d3354d8c294ba466bc904bde98fa

>   src/test/java/org/apache/aurora/scheduler/sla/SlaUtilTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54106/diff/
> 
> 
> Testing
> -------
> 
> Tests added and modified to match the continuous distribution.
> I also exported the tests into excel and check the reports percentiles.
> 
> 
> Thanks,
> 
> Reza Motamedi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message