aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 54176: Update PMD and checkstyle.
Date Tue, 29 Nov 2016 22:15:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54176/#review157340
-----------------------------------------------------------



Master (8e07b04) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 29, 2016, 10:02 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54176/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 10:02 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This updates PMD to 5.5.2 and checkstyle to 7.3. The included code
> change was reported by the latest PMD version, i.e. exceptions
> will be picked up automatically. There is no need for a placeholder.
> 
> Changelogs:
> 
> * https://pmd.github.io/pmd-5.5.2/overview/changelog.html
> * http://checkstyle.sourceforge.net/releasenotes.html
> 
> 
> Diffs
> -----
> 
>   build.gradle a586ad0d57350df16c6855b226b56a2f80f1894f 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 7c8047a7235a937c29fe96517242923ff84a080c

> 
> Diff: https://reviews.apache.org/r/54176/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message