aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 54011: Add benchmarks for `StateManagerImpl`.
Date Wed, 23 Nov 2016 19:44:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54011/
-----------------------------------------------------------

(Updated Nov. 23, 2016, 11:44 a.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Changes
-------

Serb's feedback.


Bugs: AURORA-1823
    https://issues.apache.org/jira/browse/AURORA-1823


Repository: aurora


Description
-------

`StateManagerImpl` is in the middle of every task state transition in the
scheduler. Performance improvements here could yield scheduling throughput
improvements across the board. This adds benchmarks for the two bulk APIs,
inserting pending tasks and deleting tasks. Sample output:

````
Benchmark                                               (numPendingTasks)  (numTasksToDelete)
  Mode  Cnt  Score   Error  Units
StateManagerBenchmarks.DeleteTasksBenchmark.run                       N/A                1000
 thrpt   10  2.510 ± 0.557  ops/s
StateManagerBenchmarks.DeleteTasksBenchmark.run                       N/A               10000
 thrpt   10  0.272 ± 0.030  ops/s
StateManagerBenchmarks.DeleteTasksBenchmark.run                       N/A               50000
 thrpt   10  0.053 ± 0.011  ops/s
StateManagerBenchmarks.InsertPendingTasksBenchmark.run               1000                
N/A  thrpt   10  2.446 ± 0.698  ops/s
StateManagerBenchmarks.InsertPendingTasksBenchmark.run              10000                
N/A  thrpt   10  0.246 ± 0.018  ops/s
StateManagerBenchmarks.InsertPendingTasksBenchmark.run              50000                
N/A  thrpt   10  0.041 ± 0.006  ops/s
````


Diffs (updated)
-----

  src/jmh/java/org/apache/aurora/benchmark/StateManagerBenchmarks.java PRE-CREATION 

Diff: https://reviews.apache.org/r/54011/diff/


Testing
-------


Thanks,

Zameer Manji


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message