aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 53928: Speedup preemption by eliminating costly sting formatting.
Date Sat, 19 Nov 2016 14:41:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53928/#review156397
-----------------------------------------------------------



Master (203da70) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 19, 2016, 2:23 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53928/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2016, 2:23 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Before:
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                  1  thrpt
  10  16.011 ± 0.323  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                 10  thrpt
  10  15.141 ± 3.774  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                100  thrpt
  10  16.178 ± 3.710  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark               1000  thrpt
  10  16.358 ± 0.540  ops/s
> 
> After:
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                  1  thrpt
  10  41.832 ± 1.412  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                 10  thrpt
  10  46.049 ± 3.435  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                100  thrpt
  10  44.199 ± 1.272  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark               1000  thrpt
  10  38.722 ± 0.773  ops/s
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java d808c4cd2827f465cbd784a4d9d0fa496a7f8700

>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorMetrics.java 30bb814148b271cc9dfeebe016e8f8f92c2e3e41

> 
> Diff: https://reviews.apache.org/r/53928/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> ./gradlew jmh -Pbenchmarks='SchedulingBenchmarks.PreemptorSlotSearchBenchmark'
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message