aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Renan DelValle <rdelv...@binghamton.edu>
Subject Re: Review Request 53831: Filter out resources that Aurora does not yet support to avoid crashing
Date Sat, 19 Nov 2016 02:45:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53831/
-----------------------------------------------------------

(Updated Nov. 18, 2016, 6:45 p.m.)


Review request for Aurora, David McLaughlin, Joshua Cohen, and Zameer Manji.


Changes
-------

Added filters whenever fromResource is called for a Protos.Resource in order to avoid Aurora
crashing. Previously only bagFromMesosResources was using the SUPPORTED_RESOURCE filter.

Tested by having a vagrant cluster run with an unsupported resource for an hour this time
in order to make sure it works. End to end testing has been re-done. 

Ignore the previous review request.


Repository: aurora


Description
-------

Placed filter when creating resource bags from Mesos resources in to avoid trying to conver
unsupported resources which leads to the scheduler crashing.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 589288dc877d74eea1de65715fc498523be43d7f


Diff: https://reviews.apache.org/r/53831/diff/


Testing
-------

./build-support/jenkins/build.sh

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

End to end testing finally passed after trying it 2 times, failures seem to be unrelated to
this patch.


Thanks,

Renan DelValle


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message