aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 53836: Get pants using the same thrift binary as gradle.
Date Thu, 17 Nov 2016 23:27:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53836/#review156262
-----------------------------------------------------------



I'm seeing intermittent failures running the e2e tests with this patch applied. That's not
necessarily alarming, as we've had reports of this on master as well, however the behavior
in the event of these failures is different with this patch applied. See this gist which contains
the full output: https://gist.github.com/jcohen/ee69208fbca714d3f3437e4039961edf. Note the
failure about 80% through, followed by some strange compile issues?

- Joshua Cohen


On Nov. 17, 2016, 4:46 a.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53836/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2016, 4:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This required an upgrade to the latest pants dev release to correct
> an issue with the setup.py binary packager we use to generate sdists.
> 
> This is for sanity sake, and, once the TODO in
> `build-support/thrift/prepare_binary.sh` is addressed, it will also
> allow pants-patch-free addition of new platforms (thinking ARM).
> 
>  api/src/main/thrift/org/apache/aurora/gen/BUILD                        |  3 +++
>  api/src/main/thrift/org/apache/thermos/BUILD                           |  1 +
>  build-support/thrift/.gitignore                                        |  1 +
>  build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch        | 42 +++++++++++++------------------
>  build-support/thrift/AURORA-1727.lib.py.setup.py.patch                 | 45 +++++++++++++++++++++++++++++++++
>  {api/src/main/thrift/org/apache/thermos => build-support/thrift}/BUILD | 18 ++++---------
>  build-support/thrift/Makefile                                          |  2 +-
>  build-support/thrift/prepare_binary.sh                                 | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  build-support/thrift/thriftw                                           | 12 +++++++--
>  pants.ini                                                              |  7 +++++-
>  10 files changed, 158 insertions(+), 41 deletions(-)
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD f4004a3ca36078c6d24991db4beb68903a05652c

>   api/src/main/thrift/org/apache/thermos/BUILD cb655a2fd35d22f7d7e80c4311742bad763d8614

>   build-support/thrift/.gitignore 9a3adb69210ba3dbf3c1f408895561da37e8f4c3 
>   build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch b69e3fef137cd73c6f2b73201463a0705ef8082a

>   build-support/thrift/AURORA-1727.lib.py.setup.py.patch PRE-CREATION 
>   build-support/thrift/BUILD PRE-CREATION 
>   build-support/thrift/Makefile 48b174ad622288d2738a5fa37bbb72385fcc3a27 
>   build-support/thrift/prepare_binary.sh PRE-CREATION 
>   build-support/thrift/thriftw 50d6dfdeb16ca8bf14aaff7aa826e3d69c5e13f0 
>   pants.ini cecdb277f327f77b2652f76a30fc8d4ffd9ff1db 
> 
> Diff: https://reviews.apache.org/r/53836/diff/
> 
> 
> Testing
> -------
> 
> Locally green:
> ```
> rm -rf ~/.cache/pants .cache/
> git clean -fdx build-support/thrift
> ./pants clean-all
> ./build-support/jenkins/build.sh
> 
> vagrant ssh --command "rm -rf ~/.cache/pants && cd aurora && rm -rf .cache/
&& ./pants clean-all"
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> ./build-support/python/make-pycharm-virtualenv
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message