aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 53508: Fix regression in 5410c22.
Date Sat, 05 Nov 2016 01:06:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/#review155038
-----------------------------------------------------------


Ship it!




Ship It!

- Joshua Cohen


On Nov. 5, 2016, 12:53 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53508/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2016, 12:53 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
> and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/ and
> wraps the `prcl(2)` call in a try except block.
> 
> This also exposed some flakyness in
> `TestRunnerKillProcessGroup.test_pg_is_killed`. Marked the test as flaky and
> filed AURORA-1809.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87 
>   src/main/python/apache/thermos/common/process_util.py c63b9aff2a9a453ca921308baa4d1d1762ae3a40

>   src/main/python/apache/thermos/core/process.py 13f9ad5711edde3a0a0d47ba6db1c199434e6802

>   src/test/python/apache/thermos/core/test_staged_kill.py 9167e6082d72aed9aa6aa4bb209c83f9d53c8ae8

> 
> Diff: https://reviews.apache.org/r/53508/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --junit-xml-dir="$PWD/dist/test-results" src/{main,test}/python::
-- -v
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message