aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 53508: Fix regression in 5410c22.
Date Sat, 05 Nov 2016 00:35:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/#review155032
-----------------------------------------------------------



Master (5410c22) is red with this patch.
  ./build-support/jenkins/build.sh

                         
                           ps = ProcessProviderFactory.get()
                           ps.collect_all()
                           assert parent_pid in ps.pids()
                           assert child_pid in ps.pids()
                           assert child_pid in ps.children_of(parent_pid)
                         
                           with open(os.path.join(runner.sandbox, runner.task_id, 'exit.txt'),
'w') as fp:
                             fp.write('go away!')
                         
                           while tm.task_state() is not TaskState.SUCCESS:
                             time.sleep(0.1)
                         
                           state = tm.get_state()
                           assert state.processes['process'][0].state == ProcessState.SUCCESS
                         
                           ps.collect_all()
                           assert parent_pid not in ps.pids()
                     >     assert child_pid not in ps.pids()
                     E     assert 30475 not in set([1, 2, 3, 5, 7, 8, ...])
                     E      +  where set([1, 2, 3, 5, 7, 8, ...]) = <bound method
ProcessProvider_Procfs.pids of <twitter.common.process.process_provider_procfs.ProcessProvider_Procfs
object at 0x7f0c798b1990>>()
                     E      +    where <bound method ProcessProvider_Procfs.pids
of <twitter.common.process.process_provider_procfs.ProcessProvider_Procfs object at 0x7f0c798b1990>>
= <twitter.common.process.process_provider_procfs.ProcessProvider_Procfs object at 0x7f0c798b1990>.pids
                     
                     src/test/python/apache/thermos/core/test_staged_kill.py:287: AssertionError
                     -------------- Captured stderr call --------------
                     WARNING:root:Could not read from checkpoint /tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
                     WARNING:root:Could not read from checkpoint /tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
                     WARNING:root:Could not read from checkpoint /tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
                     WARNING:root:Could not read from checkpoint /tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
                     WARNING:root:Could not read from checkpoint /tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
                     WARNING:root:Could not read from checkpoint /tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
                     WARNING:root:Could not read from checkpoint /tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

                      1 failed, 719 passed, 6 skipped, 1 warnings in 206.00 seconds

                     
FAILURE


00:35:12 03:45   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 4, 2016, 11:54 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53508/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 11:54 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
> and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/ and
> wraps the `prcl(2)` call in a try except block.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87 
>   src/main/python/apache/thermos/common/process_util.py c63b9aff2a9a453ca921308baa4d1d1762ae3a40

>   src/main/python/apache/thermos/core/process.py 13f9ad5711edde3a0a0d47ba6db1c199434e6802

> 
> Diff: https://reviews.apache.org/r/53508/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --junit-xml-dir="$PWD/dist/test-results" src/{main,test}/python::
-- -v
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message