aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradyumna Kaushik <pkaus...@binghamton.edu>
Subject Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint
Date Thu, 03 Nov 2016 22:46:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51993/
-----------------------------------------------------------

(Updated Nov. 3, 2016, 10:46 p.m.)


Review request for Aurora and Joshua Cohen.


Changes
-------

Dropped @VisibleForTesting annotation for public constructor of NearestFit.java. Modified
NearestFit#getPendingReasons(...) to use streams instead. Reverted OffersTest.java. Added
another TaskGroup to PendingTasksTest#testOffers() to ensure that the reasons are mapped to
the correct TaskGroupKey. Compared objects instead of strings in PendingTasksTest.java and
NearestFitTest#getPendingReasons(...). Removed unnecessary tabs in the source code. Moved
PendingTasksTest#makeTask(...) and NearestFitTest#makeTask(...) to a utility class src/test/java/org/apache/aurora/scheduler/http/TestUtils.java.
Used JsonNode#asText() instead of JsonNode#toString()#replace(...) in PendingTasks#getOffers().


Bugs: AURORA-1762
    https://issues.apache.org/jira/browse/AURORA-1762


Repository: aurora


Description
-------

Added the 'reason' to the /pendingTasks endpoint


Diffs (updated)
-----

  config/legacy_untested_classes.txt 84265066001dee79df6bc16de6de9a165e912b9b 
  src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java c80e0c8adf80e12082a6952ae79b7d9cc960c5b6

  src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java f783e7ff220573915524a1efc27141193d19fa6c

  src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java b521620badff76e8fab0bdf31f8a73c4019b2121

  src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 77187bc19fb1f783d1b820d324c7fe18e509365f

  src/test/java/org/apache/aurora/scheduler/http/OffersTest.java 9e3573252cf37153180b1fc5ab9150bab0299c99

  src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/http/TestUtils.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java d9b3cc672f42c50b2a2a142733d26c0725bbc864


Diff: https://reviews.apache.org/r/51993/diff/


Testing
-------

./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Pradyumna Kaushik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message