aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.
Date Tue, 01 Nov 2016 01:40:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53333/#review154360
-----------------------------------------------------------



Master (13d4861) is red with this patch.
  ./build-support/jenkins/build.sh

Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 cffi-1.7.0 cov-core-1.15.0
coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 lmdb-0.89 monotonic-1.2 packaging-16.7
pantsbuild.pants-1.3.0.dev0 pathspec-0.3.4 pex-1.1.13 psutil-4.3.0 py-1.4.31 pycparser-2.17
pyparsing-2.1.10 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 pywatchman-1.3.0 requests-2.5.3
scandir-1.2 setproctitle-1.1.10 setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.9
twitter.common.confluence-0.3.9 twitter.common.dirutil-0.3.9 twitter.common.lang-0.3.9 twitter.common.log-0.3.9
twitter.common.options-0.3.9

01:39:46 00:00 [main]
               (To run a reporting server: ./pants server)
01:39:46 00:00   [setup]
01:39:46 00:00     [parse]
               Executing tasks in goals: compile
01:39:46 00:00   [compile]
01:39:46 00:00     [compile-prep-command]
01:39:46 00:00     [compile]
01:39:46 00:00     [python-eval]
01:39:46 00:00     [pythonstyle]
01:39:47 00:01       [cache]                                          
                   No cached artifacts for 42 targets.
                   Invalidated 42 targets.
T302:ERROR   src/test/python/apache/aurora/config/test_thrift.py:113 Expected 2 blank lines,
found 1
     |def test_config_with_volumes():

E302:ERROR   PythonFile(src/test/python/apache/aurora/config/test_thrift.py):113 expected
2 blank lines, found 1
     |def test_config_with_volumes():


T100:ERROR   src/main/python/apache/aurora/config/thrift.py:177 Indentation of 4 instead of
2
     |    thrift_volumes = []

T100:ERROR   src/main/python/apache/aurora/config/thrift.py:180 Indentation of 4 instead of
2
     |        mode = parse_enum(Mode, v.mode())

T302:ERROR   src/main/python/apache/aurora/config/thrift.py:190 Expected 2 blank lines, found
1
     |def image_to_thrift(image):

E302:ERROR   PythonFile(src/main/python/apache/aurora/config/thrift.py):190 expected 2 blank
lines, found 1
     |def image_to_thrift(image):


FAILURE: 6 Python Style issues found. For import order related issues, please try `./pants
fmt.isort <targets>`


01:40:05 00:19   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 1, 2016, 1:23 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53333/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2016, 1:23 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and Stephan Erb.
> 
> 
> Bugs: AURORA-1107
>     https://issues.apache.org/jira/browse/AURORA-1107
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Enables the client DSL to set per task volume mounts. This also adds a E2E test that
tests per task volume mounting.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler.conf e68a801017ae02e0ed581129e12a645ccc1e35d4

>   src/main/python/apache/aurora/config/schema/base.py 845163043b0b7b2f9e7aca14677ca9f094658551

>   src/main/python/apache/aurora/config/thrift.py 3539469d243638c0acd08bf0859d0ce858d8977c

>   src/test/python/apache/aurora/config/test_thrift.py e213184739167e01f3614c20a809af39b3a6b3d6

>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c71fb81490863b44827bf090f6e5a6b28da94b93

>   src/test/sh/org/apache/aurora/e2e/run-server.sh 1fe09090bfa3eeb0f6897e8c895782fb1ff949a1

> 
> Diff: https://reviews.apache.org/r/53333/diff/
> 
> 
> Testing
> -------
> 
> sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message