aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint
Date Wed, 05 Oct 2016 19:46:10 GMT
That would be the perfect place for the test, thanks for adding it!

On Wed, Oct 5, 2016 at 2:43 PM, Pradyumna Kaushik <pkaushi1@binghamton.edu>
wrote:

> Zameer,
>
> Alright. I will start making changes to incorporate Stephan's idea.
> Also, I didn't seem to find an existing test for PendingTasks. Please let
> me know whether I can go ahead and create PendingTasksTest.java in
> src/test/java/scheduler/http. If not, then please let me know where I can
> plug in the JUnit tests for /pendingTasks api.
>
> On Wed, Oct 5, 2016 at 3:21 PM, Zameer Manji <zmanji@apache.org> wrote:
>
>> If you don't think it's too much work, I think Stephan's idea is ideal.
>>
>> The mutability of `reason` can result in bugs later.
>>
>> On Wed, Oct 5, 2016 at 11:31 AM, Pradyumna Kaushik <
>> pkaushi1@binghamton.edu> wrote:
>>
>>> Hi,
>>>
>>> Should I go ahead and work on Stephan's idea of returning a Map<GroupID,
>>> String>  or should I hold it for now until the idea is a little more clear?
>>>
>>> On Tue, Oct 4, 2016 at 5:18 PM, Zameer Manji <zmanji@apache.org> wrote:
>>>
>>>> This is an automatically generated e-mail. To reply, visit:
>>>> https://reviews.apache.org/r/51993/
>>>>
>>>> On October 4th, 2016, 2:10 p.m. PDT, *Stephan Erb* wrote:
>>>>
>>>> This change will be backwards incompatible. For example, it will break the
Prometheus Aurora exporter: https://github.com/tommyulfsparre/aurora_exporter/blob/master/main.go#L101
>>>>
>>>> So the question: Do we consider this endpoint to be part of our public API?
If yes, how can we remain backwards compatible?
>>>>
>>>> I'm not sure if we do make this endpoint apart of our public API, but I think
we can make a backwards compatible change here.
>>>>
>>>> The current schema of the endpoint is list of objects where each object has
the keys:
>>>> - penaltyMs (string)
>>>> - taskIds (list of strings)
>>>> - name (string)
>>>>
>>>> Surely we can add "reason" there as a list of strings.
>>>>
>>>>
>>>> - Zameer
>>>>
>>>> On October 4th, 2016, 11:25 a.m. PDT, Pradyumna Kaushik wrote:
>>>> Review request for Aurora and Joshua Cohen.
>>>> By Pradyumna Kaushik.
>>>>
>>>> *Updated Oct. 4, 2016, 11:25 a.m.*
>>>> *Repository: * aurora
>>>> Description
>>>>
>>>> Added the 'reason' to the /pendingTasks endpoint
>>>>
>>>> Testing
>>>>
>>>> ./build-support/jenkins/build.sh
>>>> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>>>>
>>>> Diffs
>>>>
>>>>    - src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java
>>>>    (c80e0c8adf80e12082a6952ae79b7d9cc960c5b6)
>>>>    - src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java
>>>>    (f783e7ff220573915524a1efc27141193d19fa6c)
>>>>    - src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java
>>>>    (5d319557057e27fd5fc6d3e553e9ca9139399c50)
>>>>
>>>> View Diff <https://reviews.apache.org/r/51993/diff/>
>>>>
>>>
>>>
>>>
>>> --
>>> Thanks and Regards
>>> Pradyumna Kaushik
>>>
>>> *Graduate Student*
>>> *Department of Computer Science*
>>> *Thomas J. Watson School of Engineering and Applied Science*
>>> *Binghamton University*
>>>
>>
>>
>>
>> --
>> Zameer Manji
>>
>
>
>
> --
> Thanks and Regards
> Pradyumna Kaushik
>
> *Graduate Student*
> *Department of Computer Science*
> *Thomas J. Watson School of Engineering and Applied Science*
> *Binghamton University*
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message