aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 53258: Added short example to documentation how to use .thermos_profile
Date Mon, 31 Oct 2016 14:24:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53258/#review154259
-----------------------------------------------------------


Ship it!




Can you clean up the trailing whitespace showing up in red in the reviewboard diff? Other
than that and the small technical detail below, looks good. Thanks for adding this!


docs/reference/configuration-tutorial.md (line 248)
<https://reviews.apache.org/r/53258/#comment223759>

    nit: this is not done when the sandbox is created, this is done whenever a process is
forked.
    
    (Not necessary for the doc, but for the sake of completeness, the file, if it exists is
set to `BASH_ENV` in the environment of the forked process (whose cmdline itself is wrapped
in a `bash -c` invocation)).


- Joshua Cohen


On Oct. 28, 2016, 10:08 a.m., Rogier Dikkes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53258/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2016, 10:08 a.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added short example to documentation how to use .thermos_profile
> 
> 
> Diffs
> -----
> 
>   docs/reference/configuration-tutorial.md c0e573bdb9d1c0e649e5d272d64c4bc54357f74f 
> 
> Diff: https://reviews.apache.org/r/53258/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rogier Dikkes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message