aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 52915: Upgrade pants to the 1.3.0 dev series.
Date Sun, 23 Oct 2016 18:12:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52915/#review153659
-----------------------------------------------------------



Sorry for the delay submitting this, e2e didn't actually pass and I futzed with this for a
while.
At the end of the day I needed to re-introduce `examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout`
containing `1mins` to get e2e to pass on my machine.
That's unrelated though so I'll submit this presently and swing back with a change to add
that.

- John Sirois


On Oct. 15, 2016, 4:42 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52915/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2016, 4:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This gets rid of an impossible to work around warning emitted by every
> pants invocation and prepares for consuming an upcoming pants change
> that will allow Aurora to use the thrift binary selected by
> `build-support/thrift/thriftw` consistently everywhere.
> 
> Release notes are here:
>   http://www.pantsbuild.org/notes-master.html
> 
>  pants.ini | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> 
> Diffs
> -----
> 
>   pants.ini 6ed4186780c485f2d023d8e398429e570e9e5a0c 
> 
> Diff: https://reviews.apache.org/r/52915/diff/
> 
> 
> Testing
> -------
> 
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./build-support/python/make-pycharm-virtualenv
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message