aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradyumna Kaushik <pkaus...@binghamton.edu>
Subject Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint
Date Sat, 15 Oct 2016 18:39:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51993/
-----------------------------------------------------------

(Updated Oct. 15, 2016, 6:39 p.m.)


Review request for Aurora and Joshua Cohen.


Changes
-------

The attribute "reason" is no longer a member of TaskGroup.java. The "reason" attribute is
added to the resultant JSON instead. NearestFit#getPendingReasons(...) now returns a Map<TaskGroupKey,
List<String> where the values are a list of reasons for the tasks to be pending. Annotated
constructors of TaskGroups.java and TaskGroup.java with @VisibleForTesting as I need to use
these for testing PendingTasks#getOffers() and NearestFit#getPendingReasons(...).


Repository: aurora


Description
-------

Added the 'reason' to the /pendingTasks endpoint


Diffs (updated)
-----

  config/legacy_untested_classes.txt ee4d3d7e537356ae99ba3a90a3631749067662f3 
  hs_err_pid19201.log PRE-CREATION 
  hs_err_pid19238.log PRE-CREATION 
  hs_err_pid31222.log PRE-CREATION 
  replay_pid31222.log PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java c80e0c8adf80e12082a6952ae79b7d9cc960c5b6

  src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java f783e7ff220573915524a1efc27141193d19fa6c

  src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java 5d319557057e27fd5fc6d3e553e9ca9139399c50

  src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java d390c07522d22e43d79ce4370985f3643ef021ca

  src/test/java/org/apache/aurora/scheduler/http/OffersTest.java 9e3573252cf37153180b1fc5ab9150bab0299c99

  src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java d9b3cc672f42c50b2a2a142733d26c0725bbc864


Diff: https://reviews.apache.org/r/51993/diff/


Testing
-------

./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Pradyumna Kaushik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message