aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Pinkul <jpin...@live.com>
Subject Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.
Date Wed, 12 Oct 2016 19:42:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/
-----------------------------------------------------------

(Updated Oct. 12, 2016, 12:42 p.m.)


Review request for Aurora, Joshua Cohen and Zameer Manji.


Bugs: AURORA-1789
    https://issues.apache.org/jira/browse/AURORA-1789


Repository: aurora


Description
-------

Adding an error message when the mesos_containerizer_path is not set correctly.


Diffs
-----

  src/main/python/apache/aurora/executor/thermos_task_runner.py efa51e162de28c9d96fc898b87a1f63843928829


Diff: https://reviews.apache.org/r/52804/diff/


Testing
-------

I verified the new error makes its way to the UI when mesos_containerizer_path is set to a
file that does not exist and also verified the executors complates succesfully when mesos_containerizer_path
is set to the correct location.

Unit tests:
```
./pants test src/test/python/apache/thermos::
./pants test src/test/python/apache/aurora/executor::
```


Thanks,

Justin Pinkul


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message