aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer
Date Tue, 11 Oct 2016 21:30:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52479/#review152200
-----------------------------------------------------------



This is just a first pass, mostly style stuff. Need to circle back around to the tests.


docs/features/containers.md (line 71)
<https://reviews.apache.org/r/52479/#comment221059>

    "Starting with the 0.17.0 release, ..."



docs/features/containers.md (lines 72 - 73)
<https://reviews.apache.org/r/52479/#comment221060>

    "This ensures that the job always uses the same image across restarts, even if the version
identified by the tag has been updated, guaranteeing that only job updates can mutate configuration."



docs/features/containers.md (line 115)
<https://reviews.apache.org/r/52479/#comment221061>

    "Not, this feature requires a v2 Docker registry."
    
    (Also lowercase registry throughout.)



docs/features/containers.md (line 118)
<https://reviews.apache.org/r/52479/#comment221062>

    s/repositories/registries
    s/tp/to
    s/docker configuration/Docker configuration



docs/features/containers.md (line 119)
<https://reviews.apache.org/r/52479/#comment221063>

    s/which defaults to/and defaults to



examples/vagrant/provision-dev-cluster.sh (lines 60 - 70)
<https://reviews.apache.org/r/52479/#comment221064>

    Does this need to be done during provisioning? Or should it be done as part of the base
box?



src/main/python/apache/aurora/client/docker/docker_client.py (line 51)
<https://reviews.apache.org/r/52479/#comment221069>

    Since we treat all non-200 responses as exceptions, should we just `raise_for_status`
immediately after making the request?



src/main/python/apache/aurora/client/docker/docker_client.py (line 68)
<https://reviews.apache.org/r/52479/#comment221066>

    Any reason you went with this capitalization? The canonical capitalization in the RFC
is `WWW-Authenticate`, but http headers should also be case insensitive.



src/main/python/apache/aurora/client/docker/docker_client.py (line 111)
<https://reviews.apache.org/r/52479/#comment221070>

    maybe use urlparse here?


- Joshua Cohen


On Oct. 11, 2016, 4:06 a.m., Santhosh Kumar Shanmugham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52479/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2016, 4:06 a.m.)
> 
> 
> Review request for Aurora, George Sirois, Joshua Cohen, John Sirois, and Brian Wickman.
> 
> 
> Bugs: AURORA-1014
>     https://issues.apache.org/jira/browse/AURORA-1014
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Resolve docker tags to concrete identifiers for DockerContainerizer
> 
> Docker tags are mutable and can point to different different images
> at different points in time. This makes a job launched with a Docker
> image to be mutable across restarts of the job. This breaks Aurora's
> guarantee of job immutability (except via job updates).
> 
> This change introduces a binding helper, that resolves docker name:tag
> to a concrete registry/name@digest identifier. Identifying
> docker images via a content-addressable digest is available via the
> Docker Registry v2, that is a prerequisite for this feature.
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt 398338966ba715fae523ee4d12afbba4c0eb6bbb 
>   RELEASE-NOTES.md f3dd8bb0f983c560f29ac39824e517c9f145d69e 
>   docs/features/containers.md 8af38e3af989351925a4130da1ce7a0f5853f0bf 
>   examples/jobs/hello_docker_engine.aurora 3c830e8f99f07732ae985b0aad114c3346888765 
>   examples/vagrant/provision-dev-cluster.sh 66b99cfbd55ab7becfa9534213cc5ea9bdbb3a74

>   src/main/python/apache/aurora/client/binding_helpers/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/client/binding_helpers/__init__.py PRE-CREATION 
>   src/main/python/apache/aurora/client/binding_helpers/docker_helper.py PRE-CREATION

>   src/main/python/apache/aurora/client/cli/client.py fa0c2648c5ff7ea6c9d949cf8cd9b9795d452e98

>   src/main/python/apache/aurora/client/docker/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/client/docker/__init__.py PRE-CREATION 
>   src/main/python/apache/aurora/client/docker/docker_client.py PRE-CREATION 
>   src/main/python/apache/aurora/config/schema/base.py baea660a6ea9f3f7213f98f8bfdb95d912083ac0

>   src/test/python/apache/aurora/client/binding_helpers/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/client/binding_helpers/__init__.py PRE-CREATION 
>   src/test/python/apache/aurora/client/binding_helpers/test_docker_helper.py PRE-CREATION

>   src/test/python/apache/aurora/client/docker/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/client/docker/__init__.py PRE-CREATION 
>   src/test/python/apache/aurora/client/docker/test_docker_client.py PRE-CREATION 
>   src/test/python/apache/aurora/config/BUILD 52b60409e1de2f69f181a83720ebe1c649b49166

>   src/test/python/apache/aurora/config/test_base.py b354f0804ce70682e8ecb9fb3a3d8fe736fd1cc5

>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c71fb81490863b44827bf090f6e5a6b28da94b93

>   src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora 4fa387d5184968e456bf4c8388496f0514454cb1

>   src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora b279b4f679cc6843e99806bcbf57350ba1c9a6e0

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh c93be9b4b4c76186445ae13eb9424bbf9de9b202

> 
> Diff: https://reviews.apache.org/r/52479/diff/
> 
> 
> Testing
> -------
> 
> build-support/jenkins/build.sh
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message