aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 52610: Use the Thrift binary protocol in the Aurora client.
Date Thu, 06 Oct 2016 19:14:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52610/#review151707
-----------------------------------------------------------


Ship it!




Ship It!

- John Sirois


On Oct. 6, 2016, 12:14 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52610/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2016, 12:14 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Now that Aurora 0.16 has been released, we can assume all schedulers are
> supporting the binary protocol.
> 
> Switching the protocol comes with a slight performance boost: Given
> the example job `devcluster/www-data/prod/hello` with 500 instances
> we can reduce the average request time by about 40%.
> 
> Using the TJSONProtocol:
> 
>     $ time aurora job status devcluster > /dev/null
>     real    0m0.906s
>     user    0m0.759s
>     sys     0m0.078s
> 
> Using the new TBinaryProtocol:
> 
>     $ time aurora job status devcluster > /dev/null
>     real    0m0.524s
>     user    0m0.410s
>     sys     0m0.079s
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 6968bb538a57c2583316175f74683dcf3de2b297 
>   src/main/python/apache/aurora/client/api/scheduler_client.py cbdb50ae409b70a35a03405f969d02a6145c9c53

>   src/main/python/apache/aurora/common/transport.py 2e38847c1bfe24961cc2ee1619a223481d1646a7

>   src/test/python/apache/aurora/common/test_transport.py 0a587f00a6a00106d6f6b756aaa3078fb042e3b3

> 
> Diff: https://reviews.apache.org/r/52610/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message