aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 52591: Remove untested classes that no longer exist.
Date Thu, 06 Oct 2016 15:30:46 GMT


> On Oct. 5, 2016, 9:51 p.m., Zameer Manji wrote:
> > How did you determine this?

Like so:
```
$ sed -r -e 's|\$.*||' -e 's|$|.java|' config/legacy_untested_classes.txt | sort -u | while
read file; do test -f src/main/java/$file || echo "DNE: $file"; done
DNE: org/apache/aurora/auth/CapabilityValidator.java
DNE: org/apache/aurora/auth/UnsecureAuthModule.java
DNE: org/apache/aurora/scheduler/async/OfferQueue.java
```


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52591/#review151625
-----------------------------------------------------------


On Oct. 6, 2016, 9:30 a.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52591/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2016, 9:30 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> config/legacy_untested_classes.txt | 6 ------
>  1 file changed, 6 deletions(-)
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt ee4d3d7e537356ae99ba3a90a3631749067662f3 
> 
> Diff: https://reviews.apache.org/r/52591/diff/
> 
> 
> Testing
> -------
> 
> Locally green: `./gradlew -Pq build`
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message