aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 52581: Reduce offer_filter_duration to 0secs in Vagrant
Date Wed, 05 Oct 2016 23:32:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52581/#review151588
-----------------------------------------------------------


Ship it!




presumably a near-zero jitter would help as well: https://github.com/apache/aurora/blob/783baaefb9a814ca01fad78181fe3df3de5b34af/src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java#L40

- John Sirois


On Oct. 5, 2016, 5:23 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52581/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2016, 5:23 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This was more a random experiment on my end. We use this value in production as our clusters
are rather small and it can happen that `#instances in a job >> #agents`, so a smaller
filter duration increases scheduling performance. Turns out this is also slightly helpful
in our e2e tests:
> 
> Before the patch:
> 
>     real   	27m52.457s
>     user   	0m2.308s
>     sys    	0m0.938s
> 
> with the patch:
> 
>     real   	23m56.899s
>     user   	0m2.277s
>     sys    	0m0.884s
>     
> Both experiments were preceeded with a `vagrant destroy && vagrant up`. 
> 
> The improvement is minimal and could probably also due to other external factors as I
have made only one run each.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf f1852f1daac6c5379de34af713580ae4c4615548

>   examples/vagrant/upstart/aurora-scheduler.conf 91b27d7a7b3d9bfb9ccec29b52f5e0adb2e078f5

> 
> Diff: https://reviews.apache.org/r/52581/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message