aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker
Date Wed, 05 Oct 2016 22:24:59 GMT


> On Oct. 5, 2016, 3:13 p.m., Aurora ReviewBot wrote:
> > Master (640f07b) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >                              # Create file stdout for capturing output. We can't
use StringIO mock
> >                              # because TestProcess is running fork.
> >                              with open(os.path.join(td, 'sys_stdout'), 'w+')
as stdout:
> >                                with open(os.path.join(td, 'sys_stderr'), 'w+')
as stderr:
> >                                  with mutable_sys():
> >                                    sys.stdout, sys.stderr = stdout, stderr
> >                          
> >                                    p = TestProcess('process', 'echo hello world;
echo >&2 hello stderr', 0,
> >                                                    taskpath, sandbox, logger_destination=LoggerDestination.BOTH)
> >                                    p.start()
> >                                    rc = wait_for_rc(taskpath.getpath('process_checkpoint'))
> >                          
> >                                    assert rc == 0
> >                                    # Check log files were created in std path
with correct content
> >                      >             assert_log_content(taskpath, 'stdout',
'hello world\n')
> >                      
> >                      src/test/python/apache/thermos/core/test_process.py:487: 
> >                      _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> >                      
> >                      taskpath = <apache.thermos.common.path.TaskPath object at
0x7f7ded54f150>
> >                      log_name = 'stdout'
> >                      expected_content = 'hello world\n'
> >                      
> >                          def assert_log_content(taskpath, log_name, expected_content):
> >                            log = taskpath.with_filename(log_name).getpath('process_logdir')
> >                            assert os.path.exists(log)
> >                            with open(log, 'r') as fp:
> >                      >       assert fp.read() == expected_content
> >                      E       assert '' == 'hello world\n'
> >                      E         + hello world
> >                      
> >                      src/test/python/apache/thermos/core/test_process.py:313: AssertionError
> >                       generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

> >                       1 failed, 716 passed, 6 skipped, 1 warnings in 235.81
seconds 
> >                      
> > FAILURE
> > 
> > 
> > 22:12:25 04:31   [complete]
> >                FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"

How do we debug these kind of failures? This same failure happened for me as well. Is this
some flakiness that was introduced recently?


- Santhosh Kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/#review151573
-----------------------------------------------------------


On Oct. 5, 2016, 3:01 p.m., Kai Huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52453/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2016, 3:01 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-894
>     https://issues.apache.org/jira/browse/AURORA-894
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Add support for receiving a new HealthCheckConfig attribute "min_consecutive_successes"
in health checker.
> - Add an entry in release note that describes the health check driven update feature.
> 
> This patch is related to https://reviews.apache.org/r/52094/, in which I added a new
configuration value "min_consecutive_successes" in HealthCheckConfig.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 97f05d52cfd2ed481feae0d01172b5b1af72b80a 
>   docs/features/job-updates.md 792f2ae5fd14b1ea9af8be000629ce5a7fc2fe8f 
>   src/main/python/apache/aurora/client/api/updater_util.py c649316edb876565c92cc90c9f030e153c008924

>   src/main/python/apache/aurora/executor/common/health_checker.py 03fbffdc3862a94c2ba42c9b9e8f2be4094129b8

> 
> Diff: https://reviews.apache.org/r/52453/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> 
> ./pants test.pytest src/test/python/apache/aurora/executor::
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message