aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 52577: Update to Gradle 3.1.
Date Wed, 05 Oct 2016 22:20:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52577/#review151576
-----------------------------------------------------------


Ship it!




Ship It!

- John Sirois


On Oct. 5, 2016, 4:14 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52577/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2016, 4:14 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I have skimmed the release notes and this change seems to be the most
> important one:
> 
>     "This release (2.14.1) fixes a critical defect to incremental builds that
>      may prevent Gradle from executing tasks when inputs or outputs are out of
>      date. This affects the correctness of builds using Gradle 2.14."
> 
> The release notes talk about massive performance gains, but I have not noticed any. 
> 
> Since the Gradle daemon is now enabled by default, we can drop the properties file.
> 
> Release notes:
> 
> * https://docs.gradle.org/3.1/release-notes
> * https://docs.gradle.org/3.0/release-notes
> * https://docs.gradle.org/2.14/release-note
> 
> ---
> 
> *NOTE to Reviewers:* I will only ship this once I have the corresponding aurora-packaging
update in place as well.
> 
> 
> Diffs
> -----
> 
>   buildSrc/gradle.properties 8cfb32885c90aa006cad1aa00a1adac36356eac3 
>   gradle.properties 6fadce875cb8e07f75067bf9bd9d008607dd77f6 
>   gradle/wrapper/gradle-wrapper.properties afe80a346163ad9ebf97dc57473d48b8987d8357 
> 
> Diff: https://reviews.apache.org/r/52577/diff/
> 
> 
> Testing
> -------
> 
> * ./gradlew -Pq build
> * ./gradlew idea and ran the tests using IDEA
> * ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh (still running as we speak)
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message