aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 52531: AURORA-1712 Debian Jessie packagaes are embedding the mesos egg build for Ubuntu trusty
Date Tue, 04 Oct 2016 22:31:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52531/#review151416
-----------------------------------------------------------


Fix it, then Ship it!




Looks good to me, thanks!

I don't have time for 'shipping', building and uploading the packages today. So you may need
to either wait or ask one of the other comitters.


build-support/python/make-mesos-native-egg (line 57)
<https://reviews.apache.org/r/52531/#comment219735>

    It should not matter much in the executor, but please add `--enable-optimize`.



build-support/python/make-mesos-native-egg (line 78)
<https://reviews.apache.org/r/52531/#comment219733>

    How about using the 'official' one here `debian/jessie64`?



build-support/python/make-mesos-native-egg (line 134)
<https://reviews.apache.org/r/52531/#comment219734>

    Same here, official one seems to be `ubuntu/xenial64`


- Stephan Erb


On Oct. 5, 2016, 12:16 a.m., Renan DelValle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52531/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2016, 12:16 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Support for making mesos native python eggs for Debian Jessie and Ubuntu Xenial.
> 
> 
> Diffs
> -----
> 
>   build-support/python/make-mesos-native-egg 93874964b6e25ab419ca04c0fae674c3c2ce5e15

> 
> Diff: https://reviews.apache.org/r/52531/diff/
> 
> 
> Testing
> -------
> 
> ./make-mesos-native-egg jessie64 1.0.0 $(pwd)/test
> ./make-mesos-native-egg xenial64 1.0.0 $(pwd)/test
> 
> *NOTE: Have not tried installing the python eggs generated.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message