aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint
Date Tue, 04 Oct 2016 21:10:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51993/#review151391
-----------------------------------------------------------



This change will be backwards incompatible. For example, it will break the Prometheus Aurora
exporter: https://github.com/tommyulfsparre/aurora_exporter/blob/master/main.go#L101

So the question: Do we consider this endpoint to be part of our public API? If yes, how can
we remain backwards compatible?


src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java (lines 32 - 40)
<https://reviews.apache.org/r/51993/#comment219708>

    I feel like we should not add any `reason` attribute to `TaskGroup`. It is mutable and
only used in a subset of code paths where TaskGroups are used.
    
    You could make this work by changing `nearestFit.addPendingReason(taskGroups.getGroups())`
to be a `nearestFit.getPendingReason(taskGroups.getGroups())` that returns a `map<GroupID,
String>` (where String is the reason).


- Stephan Erb


On Oct. 4, 2016, 8:25 p.m., Pradyumna Kaushik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51993/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2016, 8:25 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added the 'reason' to the /pendingTasks endpoint
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java c80e0c8adf80e12082a6952ae79b7d9cc960c5b6

>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java f783e7ff220573915524a1efc27141193d19fa6c

>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java 5d319557057e27fd5fc6d3e553e9ca9139399c50

> 
> Diff: https://reviews.apache.org/r/51993/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Pradyumna Kaushik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message