aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker
Date Tue, 04 Oct 2016 19:14:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/#review151373
-----------------------------------------------------------



Changes LGTM.

Can we add documentation as well? We need to update configuration.md and I think `features/job-updates.md`
needs to be updated as well.

- Zameer Manji


On Oct. 3, 2016, 5:42 p.m., Kai Huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52453/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2016, 5:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-894
>     https://issues.apache.org/jira/browse/AURORA-894
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Add support for receiving a new HealthCheckConfig attribute "min_consecutive_successes"
in health checker.
> - Add an entry in release note that describes the health check driven update feature.
> 
> This patch is related to https://reviews.apache.org/r/52094/, in which I added a new
configuration value "min_consecutive_successes" in HealthCheckConfig.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd 
>   src/main/python/apache/aurora/client/api/updater_util.py c649316edb876565c92cc90c9f030e153c008924

>   src/main/python/apache/aurora/executor/common/health_checker.py 03fbffdc3862a94c2ba42c9b9e8f2be4094129b8

> 
> Diff: https://reviews.apache.org/r/52453/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> 
> ./pants test.pytest src/test/python/apache/aurora/executor::
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message