aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradyumna Kaushik <pkaus...@binghamton.edu>
Subject Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint
Date Tue, 04 Oct 2016 03:20:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51993/
-----------------------------------------------------------

(Updated Oct. 4, 2016, 3:20 a.m.)


Review request for Aurora and Maxim Khutornenko.


Changes
-------

Added the 'reason' to the /pendingTasks endpoint. Made addPendingReason(...) a public method
of NearestFit, as was suggested before and TaskGroups.java no longer accesses NearestFit functionality.
I am using com.google.Gson to marshall the results into a JSON. I know this is not the ideal
solution but I was getting the following exception during marshalling,

```codehaus.JSONMappingException: union is current set to ...```

, possibly due to a conflict between fasterxml and codehaus, and tried really hard to fix
it but unfortunately was not able to. I wanted to get this patch out soon and hence, I created
the workaround. I would love it if someone could give me a tip to fix the issue so that I
can then incorporate that and submit another patch.


Repository: aurora


Description
-------

Added the 'reason' to the /pendingTasks endpoint


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java c80e0c8adf80e12082a6952ae79b7d9cc960c5b6

  src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java f783e7ff220573915524a1efc27141193d19fa6c

  src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java 5d319557057e27fd5fc6d3e553e9ca9139399c50


Diff: https://reviews.apache.org/r/51993/diff/


Testing
-------

./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Pradyumna Kaushik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message