aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer
Date Mon, 03 Oct 2016 17:29:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52479/
-----------------------------------------------------------

Review request for Aurora, George Sirois and Joshua Cohen.


Bugs: AURORA-1014
    https://issues.apache.org/jira/browse/AURORA-1014


Repository: aurora


Description
-------

Resolve docker tags to concrete identifiers for DockerContainerizer

Docker tags are mutable and can point to different different images
at different points in time. This makes a job launched with a Docker
image to be mutable across restarts of the job. This breaks Aurora's
guarantee of job immutability (except via job updates).

This change introduces a binding helper, that resolves docker name:tag
to a concrete registry/name@digest identifier. Identifying
docker images via a content-addressable digest is available via the
Docker Registry v2, that is a prerequisite for this feature.


Diffs
-----

  3rdparty/python/requirements.txt 398338966ba715fae523ee4d12afbba4c0eb6bbb 
  RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd 
  docs/features/containers.md 8af38e3af989351925a4130da1ce7a0f5853f0bf 
  examples/jobs/hello_docker_engine.aurora 3c830e8f99f07732ae985b0aad114c3346888765 
  examples/vagrant/provision-dev-cluster.sh 66b99cfbd55ab7becfa9534213cc5ea9bdbb3a74 
  src/main/python/apache/aurora/config/schema/base.py baea660a6ea9f3f7213f98f8bfdb95d912083ac0

  src/test/python/apache/aurora/config/BUILD 52b60409e1de2f69f181a83720ebe1c649b49166 
  src/test/python/apache/aurora/config/test_base.py b354f0804ce70682e8ecb9fb3a3d8fe736fd1cc5

  src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c71fb81490863b44827bf090f6e5a6b28da94b93

  src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora 4fa387d5184968e456bf4c8388496f0514454cb1

  src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora b279b4f679cc6843e99806bcbf57350ba1c9a6e0

  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh c93be9b4b4c76186445ae13eb9424bbf9de9b202


Diff: https://reviews.apache.org/r/52479/diff/


Testing
-------

build-support/jenkins/build.sh
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Santhosh Kumar Shanmugham


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message