aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 52428: Add missing libffi build dep to support pants.
Date Fri, 30 Sep 2016 18:19:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52428/#review151053
-----------------------------------------------------------


Ship it!




Ship It!

- Zameer Manji


On Sept. 30, 2016, 11:17 a.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52428/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2016, 11:17 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> builder/deb/debian-jessie/Dockerfile | 1 +
>  builder/deb/ubuntu-trusty/Dockerfile | 1 +
>  builder/rpm/centos-7/Dockerfile      | 1 +
>  3 files changed, 3 insertions(+)
> 
> 
> Diffs
> -----
> 
>   builder/deb/debian-jessie/Dockerfile 4a70359f56b5c4b3a3dd30d005f39ee03707427a 
>   builder/deb/ubuntu-trusty/Dockerfile 56f81e3b0533d2a2be84e723c143dee3e6e7e79a 
>   builder/rpm/centos-7/Dockerfile 3431860708f59460dd2f6b575e23f280e903d41e 
> 
> Diff: https://reviews.apache.org/r/52428/diff/
> 
> 
> Testing
> -------
> 
> This corrects the missing deps seen here:
>   https://builds.apache.org/job/aurora-packaging-nightly/440/
> 
> Now locally green:
> ```
> (aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o snapshot.tar.gz
HEAD
> (aurora-packaging) $ ./build-artifact.sh ../aurora/snapshot.tar.gz 0.17.0-SNAPSHOT
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message