aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kai Huang <>
Subject Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig
Date Tue, 27 Sep 2016 23:30:20 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 27, 2016, 11:30 p.m.)

Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.


Rename "min_consecutive_health_checks" to "min_consecutive_successes", in accordance with
executor change. Add documentations for config change.

Bugs: AURORA-1224

Repository: aurora


Add min_consecutive_health_checks to HealthCheckConfig.

HealthCheckConfig should accept a new configuration value that will tell how many positive
consecutive health checks an instance requires to move from STARTING to RUNNING.

This review depends on the executor change(AURORA-1225). Please see
for more details and background.

[Change List]
1. Add a configuration value "min_consecutive_health_checks"(default=1) to HealthCheckConfig
2. Modify the default value of watch_secs to be 0.
3. Add a client-side constraint: 
    initial_interval_secs >= min_consecutive_health_checks * interval_secs
4. Update the unit tests for health check config in client/, skip unit tests related
to watch_secs.

Diffs (updated)

  docs/reference/ f2a0b1873f31e91f3bf0cac6f8448e8130fae688 
  src/main/python/apache/aurora/client/ 0186af52f0d7d7e3981ec59bf6a01aafee2bcfb1

  src/main/python/apache/aurora/config/schema/ 845163043b0b7b2f9e7aca14677ca9f094658551

  src/test/python/apache/aurora/client/ 5cf68a5145ddf9478baa30453c0bcb73136fa7eb




./pants test.pytest src/test/python/apache/aurora/client::

./pants test.pytest src/test/python/apache/aurora/config::


Kai Huang

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message