aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Review Request 52312: Remove `-zk_use_curator` and unused code.
Date Tue, 27 Sep 2016 19:43:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52312/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.


Bugs: AURORA-1669
    https://issues.apache.org/jira/browse/AURORA-1669


Repository: aurora


Description
-------

Some portions of the commons zookeeper package remain to be moved in a
follow-up change.

 RELEASE-NOTES.md                                                                        |
  8 +
 commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java                 |
 78 ------
 commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java             |
127 ----------
 commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java                     |
674 --------------------------------------------------
 commons/src/main/java/org/apache/aurora/common/zookeeper/JsonCodec.java                 |
 12 +-
 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java                 |
 74 ------
 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java             |
349 --------------------------
 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java                |
118 ---------
 commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java      |
122 ---------
 commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java         |
165 ------------
 commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java                 |
321 ------------------------
 commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java             |
 38 +--
 commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java         |
258 -------------------
 commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java            |
 44 ----
 commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java  |
243 ------------------
 docs/reference/scheduler-configuration.md                                               |
  2 -
 src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule.java  |
102 --------
 src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitor.java     |
 59 -----
 src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java  |
  4 +-
 src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java         |
 13 -
 src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java         |
 13 +-
 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java                |
 12 +-
 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java                          |
 45 ++--
 src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java    |
 77 ------
 src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java       |
  8 +-
 src/test/java/org/apache/aurora/scheduler/discovery/CommonsDiscoveryModuleTest.java     |
 29 ---
 src/test/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitorTest.java |
137 ----------
 src/test/java/org/apache/aurora/scheduler/discovery/CuratorDiscoveryModuleTest.java     |
 66 +++--
 src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java    |
  3 +-
 src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java            |
  5 +-
 30 files changed, 119 insertions(+), 3087 deletions(-)


Diffs
-----

  RELEASE-NOTES.md 82c9a1c73bdefc282d3d5c83f7fcfa72e61f2932 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 75c1b1493eb178ea035a0e60f20df694626c7f50

  commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 98b5ee4690482683526f2e8ce4c965ed052b0232

  commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 2720dd13a3cc5e39f7242664fbe98f00fb75eb08

  commons/src/main/java/org/apache/aurora/common/zookeeper/JsonCodec.java 9d316088ffd51b2dce816e6cc18d8e2a4a23cfd5

  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java aeea02d81faa3c8841edb9002498515dd0b52242

  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java ace4980d3e15dc830fea48b83f0688347c71d900

  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 01a54a5718388df7f02992388653d7b049422787

  commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java d9978a926e05e4303a168c7c51ee226a7dc94336

  commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java 9c0cebe888d966fd64d17778c354136df0e13c7e

  commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 97a42d1bd6c60598d7936a2c065e163c1505ef3d

  commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java 2166123e9acd701e55e10b450a9eb89054c7afdd

  commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java f0c0cb4491c7b5c34103864ee244a27db3972a94

  commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java 0e6719154ee5195111db51d323fa35c3bc56ec2b

  commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java 5f6cdd83ca6c6338f8c7a0a3c93b960c036cb05e

  docs/reference/scheduler-configuration.md 31be71491de00e53ce4764e480ff2728d06a3f1d 
  src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule.java 339f63b94e996e13514e6a6dcd7bbeef3a0f09f8

  src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitor.java 9161455c3101fb0d83633883a67ce0ffe22fcdf8

  src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java 999a542796858dcfe9e31601c47239189043fd52

  src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java e8aafe4a47e3f0e6312c8b93dbc32e1c25445dd3

  src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java 3d228da73ab656613a3e591f5e46defa233cafc9

  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 3f32a6272bb05fc5d7ffd576f6645be00114a42c

  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 29a3b4a57925f31e59a49d4bfa630e724cadcb04

  src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java d90192b10250b36c3b97055f87ff297fdf2a7dad

  src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583

  src/test/java/org/apache/aurora/scheduler/discovery/CommonsDiscoveryModuleTest.java 7a4c4dd932fa0a69f22bcbb5cba7750bba52e16d

  src/test/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitorTest.java
42a2224839f00e6938100fc315874c531cb37096 
  src/test/java/org/apache/aurora/scheduler/discovery/CuratorDiscoveryModuleTest.java f1a02e4becc5865e72aaf96334c53cb9c395d09a

  src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a

  src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java a065505134c1ad30ba9f4d4cd829355b2acc9a13


Diff: https://reviews.apache.org/r/52312/diff/


Testing
-------

Locally green: `./gradlew -Pq build`


Thanks,

John Sirois


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message