aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 52300: Running task ssh without an instance should pick a random instance
Date Tue, 27 Sep 2016 19:19:17 GMT


> On Sept. 27, 2016, 11:11 a.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/task.py, line 121
> > <https://reviews.apache.org/r/52300/diff/1/?file=1510843#file1510843line121>
> >
> >     Do you think we should require an instance a the command was specified? I'm
concerned about the scenario where running the command has a side effect on the instance.
For example, if you were to run `aurora task ssh cluster/role/env/job --command=touch .healthchecksnooze`,
after this change, that would disable health checks on (from the user's perspective) an unknown
instance.
> 
> JING CHEN wrote:
>     For the command option, as far as i know, if a instance is not speficed, the __largest__
instance will be returned and connected to, which means the command will execute on the greaetest
instace. However, in this case, at least we shoule let user know which instance they perform
on. And I am also wondering if it is easy for user to find out the greatest instance given
that there are multiple instance. I agree with you that it requires explicit instance from
user when command option is specified. Otherwise, we have to come up with a idea to make users
know the target instance. Let me know if you have addtional suggestion. Thasnks.

I'm fine with just bailing out if no instance is specified but a command is.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review150540
-----------------------------------------------------------


On Sept. 27, 2016, 10:44 a.m., JING CHEN wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 10:44 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
>     https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Running task ssh without an instance should pick the greatest instance
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/options.py 1245ff15a69a4b4347672f7b556985521e813a00

>   src/main/python/apache/aurora/client/cli/task.py a8a4edcfda8d879fcc4401bb8f5223de3ee5376d

>   src/test/python/apache/aurora/client/cli/test_options.py f2aae5741611909d5a1700cb4da70dec313e00da

> 
> Diff: https://reviews.apache.org/r/52300/diff/
> 
> 
> Testing
> -------
> 
> verified in vagrant
> 
> 
> Thanks,
> 
> JING CHEN
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message