aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.
Date Mon, 26 Sep 2016 21:42:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52276/#review150463
-----------------------------------------------------------


Ship it!




Ship It!

- Zameer Manji


On Sept. 26, 2016, 2:16 p.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52276/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 2:16 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1783
>     https://issues.apache.org/jira/browse/AURORA-1783
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Last refactoring of Webhook did not correctly close out connections so some webhook requests
would not complete.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/events/Webhook.java 66c134488f159fc25cfb2c1755b8fa23fbbdb613

>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 71aae983e9c2c34e106a931e4d25691977684b11

>   src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 6f37baaefb2910e688d7df90f3e94fc282cfb6b6

> 
> Diff: https://reviews.apache.org/r/52276/diff/
> 
> 
> Testing
> -------
> 
> Verified in vagrant + added unit tests.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message