aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 52087: Fix host maintenance commands to properly initialize the api client.
Date Tue, 20 Sep 2016 18:44:06 GMT


> On Sept. 20, 2016, 5:53 p.m., Dmitriy Shirchenko wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 272
> > <https://reviews.apache.org/r/52087/diff/1/?file=1505769#file1505769line272>
> >
> >     docstring, please!

Added.


> On Sept. 20, 2016, 5:53 p.m., Dmitriy Shirchenko wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 273
> > <https://reviews.apache.org/r/52087/diff/1/?file=1505769#file1505769line273>
> >
> >     isinstance is preferred to type since isinstance keeps track of inheritance.

Good point, fixed.


> On Sept. 20, 2016, 5:53 p.m., Dmitriy Shirchenko wrote:
> > src/main/python/apache/aurora/admin/admin_util.py, line 276
> > <https://reviews.apache.org/r/52087/diff/1/?file=1505769#file1505769line276>
> >
> >     is there a test for this switch?

Thanks for the nudge, added a few test cases.


> On Sept. 20, 2016, 5:53 p.m., Dmitriy Shirchenko wrote:
> > src/test/python/apache/aurora/admin/test_admin.py, line 232
> > <https://reviews.apache.org/r/52087/diff/1/?file=1505772#file1505772line232>
> >
> >     is there a mock with bypass_leader_redirect = True?

I think there's sufficient coverage for this on the client directly. I don't think more coverage
here buys us anything more than asserting we pass the value on from options which is of dubious
value.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52087/#review149689
-----------------------------------------------------------


On Sept. 20, 2016, 6:41 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52087/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 6:41 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1777
>     https://issues.apache.org/jira/browse/AURORA-1777
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix host maintenance commands to properly initialize the api client.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/admin.py 9fc89a2842d4651ac10aa82118531c450f051712

>   src/main/python/apache/aurora/admin/admin_util.py 394deb57af9ad8832a02ceab15f33b3c1e5c902b

>   src/main/python/apache/aurora/admin/host_maintenance.py 677f870c50d1e19d34de36a3c677bb1dcd255ba0

>   src/main/python/apache/aurora/admin/maintenance.py bf446515222a1246b7fe32acd67315f8145a1212

>   src/test/python/apache/aurora/admin/test_admin.py f720742c50f774b9f5a41ba57ef251d08d79e8d1

>   src/test/python/apache/aurora/admin/test_admin_sla.py 54b5a823903b82c2082353ade132eb7b63e518db

>   src/test/python/apache/aurora/admin/util.py d0a915cd8edee6b36d671b41f43a3af4fe751ae7

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh e36726e0c0154e51bba40704e13eebec5c0f0d65

> 
> Diff: https://reviews.apache.org/r/52087/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> ran e2e tests.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message