aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 52074: switching from launchTask to acceptOffers
Date Tue, 20 Sep 2016 03:21:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52074/#review149604
-----------------------------------------------------------



Master (4c4040f) is red with this patch.
  ./build-support/jenkins/build.sh

:commons:processResources
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74:
Note: Wrote forwarder org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor

:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java:23:
error: FakeDriver is not abstract and does not override abstract method acceptOffers(OfferID,Collection<Operation>,Filters)
in Driver
public class FakeDriver extends AbstractIdleService implements Driver {
       ^
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java:29:
error: method does not override or implement a method from a supertype
  @Override
  ^
Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
2 errors
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJmhJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to
get more log output.

BUILD FAILED

Total time: 2 mins 2.425 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 20, 2016, 2:12 a.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52074/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 2:12 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Mehrdad Nurolahzade, and Zameer Manji.
> 
> 
> Bugs: AURORA-1776
>     https://issues.apache.org/jira/browse/AURORA-1776
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Dynamic reservation requires us to use acceptOffers so this is in preparation of that
work. acceptOffers is the call to dynamically reserve resources.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/Driver.java 14481468926b82a9bad3ee78c85f176e8ba893e2

>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 41b9aab55aa439b13eba3545703ec97b44690444

>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 925c025d21bf1d44e0c1d319f6653ecfa8899481

>   src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java a739bce1226d9435fa7d0b18e411064a4e78e49e

> 
> Diff: https://reviews.apache.org/r/52074/diff/
> 
> 
> Testing
> -------
> 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message